Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[query] Move trace handler to server level #6147

Merged
merged 4 commits into from
Nov 2, 2024
Merged

[query] Move trace handler to server level #6147

merged 4 commits into from
Nov 2, 2024

Conversation

mahadzaryab1
Copy link
Collaborator

Which problem is this PR solving?

Description of the changes

  • Move the trace response handler to the server level so that it is applied to the whole server rather than just within the API handler.

How was this change tested?

  • Unit test

Checklist

@codecov Codecov
Copy link

codecov bot commented Nov 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.47%. Comparing base (43d2367) to head (8d9f3cb).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #6147   +/-   ##
=======================================
  Coverage   96.47%   96.47%           
=======================================
  Files         353      354    +1     
  Lines       20107    20107           
=======================================
  Hits        19398    19398           
  Misses        524      524           
  Partials      185      185
Flag Coverage Δ
badger_v1 8.32% <ø> (ø)
badger_v2 1.68% <ø> (ø)
cassandra-4.x-v1 14.40% <ø> (ø)
cassandra-4.x-v2 1.62% <ø> (ø)
cassandra-5.x-v1 14.40% <ø> (ø)
cassandra-5.x-v2 1.62% <ø> (ø)
elasticsearch-6.x-v1 18.53% <ø> (ø)
elasticsearch-7.x-v1 18.61% <ø> (+<0.01%) ⬆️
elasticsearch-8.x-v1 18.77% <ø> (-0.01%) ⬇️
elasticsearch-8.x-v2 1.67% <ø> (-0.02%) ⬇️
grpc_v1 9.50% <ø> (ø)
grpc_v2 7.01% <ø> (ø)
kafka-v1 8.89% <ø> (ø)
kafka-v2 1.68% <ø> (ø)
memory_v2 1.67% <ø> (-0.02%) ⬇️
opensearch-1.x-v1 18.66% <ø> (ø)
opensearch-2.x-v1 18.66% <ø> (+<0.01%) ⬆️
opensearch-2.x-v2 1.67% <ø> (ø)
tailsampling-processor 0.47% <ø> (ø)
unittests 95.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mahadzaryab1 mahadzaryab1 changed the title [WIP][query] Move trace handler to server level [query] Move trace handler to server level Nov 1, 2024
@mahadzaryab1 mahadzaryab1 marked this pull request as ready for review November 1, 2024 21:25
@mahadzaryab1 mahadzaryab1 requested a review from a team as a code owner November 1, 2024 21:25
@mahadzaryab1
Copy link
Collaborator Author

mahadzaryab1 commented Nov 1, 2024 •
edited
Loading

i believe the unit test failure is transient - rerun should fix it

@yurishkuro yurishkuro merged commit e80645b into jaegertracing:main Nov 2, 2024
51 checks passed
yurishkuro added a commit to yurishkuro/jaeger that referenced this pull request Nov 2, 2024
@yurishkuro
Revert "[query] Move trace handler to server level (jaegertracing#6147)"
c4cb41d 
This reverts commit e80645b.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@joe-elliott joe-elliott Awaiting requested review from joe-elliott joe-elliott is a code owner automatically assigned from jaegertracing/jaeger-maintainers

Assignees
No one assigned
Labels
changelog:bugfix-or-minor-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move traceResponseHandler
2 participants
@mahadzaryab1 @yurishkuro